Skip to content

[#17] Management of windows and app trait for macOS#31

Merged
stephanebouget merged 1 commit into
stephanebouget:mainfrom
pylapp:pr/17-app-window-disappear-on-outside-click
May 5, 2026
Merged

[#17] Management of windows and app trait for macOS#31
stephanebouget merged 1 commit into
stephanebouget:mainfrom
pylapp:pr/17-app-window-disappear-on-outside-click

Conversation

@pylapp
Copy link
Copy Markdown
Contributor

@pylapp pylapp commented May 4, 2026

Description

Here are the fixes with this commit:

  • consider the app as a try app, i.e. not linked to a space / workspace
  • management of focus hidding or not the windows was changed
  • when swipe between spaces, the window is still here
  • when use of Mission Control, the window is stil here
  • when outside click, window is still here
  • if PAT defined at start, display the alerts window
  • update of deprecated crates

Fixes #17

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run tests (npm run test) that prove my fix is effective or that my feature works

The management of the windows for macOS did not work.
Several things made the windows disappear: change of spaces / workspaces, management of focus, etc.
When run of the app, the browser took the prioirity over the app and displayed the PAT view instead of the app.
In addition, the management of a new run with defined token did not display the windows.

Here are the fixes with this commit:
- consider the app as a try app, i.e. not linked to a space / workspace
- management of focus hidding or not the windows was changed
- when swipe between spaces, the window is still here
- when use of Mission Control, the window is stil here
- when outside click, window is still here
- if PAT defined at start, display the alerts window

In few words, for macOS, app acts like a tray app. This is relevant with its dimensions.

Maybe this commit can solve stephanebouget#18 and stephanebouget#27

Closes stephanebouget#17

Assisted-by: Claude Sonnet 4.6 (OpenCode, LLMProxy)
Signed-off-by: Pierre-Yves Lapersonne <pierreyves.lapersonne@orange.com>
@pylapp pylapp force-pushed the pr/17-app-window-disappear-on-outside-click branch from 73af11a to 2713e02 Compare May 4, 2026 15:52
@stephanebouget stephanebouget merged commit 2713e02 into stephanebouget:main May 5, 2026
1 check passed
@stephanebouget
Copy link
Copy Markdown
Owner

Indeed,

I made a patch so that under Windows the window closes when clicking outside but it is not multi OS compatible.
I removed some unnecessary methods and managed the click under windows
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On macOS, when I click outside the init window, I loose it and cannot get it back until restart of the app

2 participants